CakePHP-Asset-Management-Plugin icon indicating copy to clipboard operation
CakePHP-Asset-Management-Plugin copied to clipboard

Node 5.x compatibility and git submodule-friendlyness

Open ctavan opened this issue 14 years ago • 2 comments

  • Move everything to root-folder so plugin can easily be added as a git submodule
  • Add node 5.x-compatible version of lessc
  • Added a package.json to easily maintain the dependencies via npm link
  • Made vendor-path independent of plugin location so plugin can be located in /plugin or /app/plugin
  • Made asset manager work in subfolders (/js and /css-URL's are passed through Router::url())

ctavan avatar Aug 27 '11 20:08 ctavan

Most of these are merged.

I wonder though why you move all the vendors one level up? Can't they stay where they are and you'd still be able to include the plugin as a submodule?

tim-kos avatar Nov 15 '11 12:11 tim-kos

Hmm, how?

git submodule add git://github.com/tim-kos/CakePHP-Asset-Management-Plugin.git plugins/assets

will clone into

plugins/assets/assets

and not work.

git submodule add git://github.com/tim-kos/CakePHP-Asset-Management-Plugin.git plugins

Will not work if you have other plugins installed...

Maybe I'm missing something? I'm not a git hero...

ctavan avatar Nov 15 '11 13:11 ctavan