aws-extend-switch-roles icon indicating copy to clipboard operation
aws-extend-switch-roles copied to clipboard

Support filtering roles that contain a path

Open dblackhall-tyro opened this issue 1 year ago • 2 comments

In my organisation some roles have been created with paths: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_identifiers.html#identifiers-friendly-names

This PR extends the matching logic to match on roles with a path

dblackhall-tyro avatar Jun 11 '24 02:06 dblackhall-tyro

I believe we need to modify the filterByTargetRole generation process. It doesn't seem to work correctly when the path consists of multiple parts. For instance, if a role path is structured like /company/dept/roleName, the current implementation might not handle it properly.

Additionally, when logging in with federated credentials, does the Management Console display usernames with paths that consist of multiple parts?

Example:

  • Role path: /company/dept/
  • Username displayed in the Management Console: company/dept/roleName

tilfin avatar Jun 11 '24 13:06 tilfin

I believe we need to modify the filterByTargetRole generation process. It doesn't seem to work correctly when the path consists of multiple parts. For instance, if a role path is structured like /company/dept/roleName, the current implementation might not handle it properly.

Going back and looking at the code again I think I understand what you mean. Should I move the logic into the convertComplexTarget function?

Additionally, when logging in with federated credentials, does the Management Console display usernames with paths that consist of multiple parts?

This I can be helpful with. The management console displays only the roleName e.g roleName/[email protected]

dblackhall-tyro avatar Jun 13 '24 03:06 dblackhall-tyro

I apologize for the delay. After carefully reviewing the PR, I can confirm that this implementation is correct and there are no issues with the processing. Thank you for your patience and contribution.

tilfin avatar Oct 26 '24 14:10 tilfin