rsvp.js icon indicating copy to clipboard operation
rsvp.js copied to clipboard

RSVP 4.0

Open stefanpenner opened this issue 11 years ago • 17 comments

checklist as time permits

  • [ ] drop helpers on RSVP namespace, all helpers that need the constructor for inheritance should end-up on Promise constructor
  • [x] new AMD build
  • [x] fast denodeify
  • [ ] drop cast
  • [ ] drop defer?
  • [ ] drop eventTarget
  • [ ] add reduce
  • [ ] error handler on by default
  • [ ] emit unhandled error stuff https://github.com/tildeio/rsvp.js/issues/417

stefanpenner avatar Jun 28 '14 22:06 stefanpenner

~~why drop cast()?~~

H1D avatar Nov 03 '14 22:11 H1D

for future readers. resolve() replaces cast() https://github.com/tildeio/rsvp.js/pull/207

H1D avatar Nov 03 '14 22:11 H1D

i have removed 2 comments unrelated to this issue, and transfered the comments to https://github.com/tildeio/rsvp.js/issues/336

stefanpenner avatar Dec 03 '14 01:12 stefanpenner

Hi, are there any plans for something like RSVP.map, .hash or .all with concurrency control? I have a use case, where I need to make a number of calls to an API that is rate-limited and specifying the number of calls that are executed in parallel would help a lot. (Similar to https://github.com/petkaantonov/bluebird/blob/master/API.md#option-concurrency)

mphasize avatar Feb 27 '15 14:02 mphasize

Hi, are there any plans for something like RSVP.map, .hash or .all with concurrency control? I have a use case, where I need to make a number of calls to an API that is rate-limited and specifying the number of calls that are executed in parallel would help a lot. (Similar to https://github.com/petkaantonov/bluebird/blob/master/API.md#option-concurrency)

their are no such plans currently.

stefanpenner avatar Feb 27 '15 16:02 stefanpenner

Thanks for clarifying, good to know. :)

mphasize avatar Feb 28 '15 16:02 mphasize

maybe also drop old IE support ?

bekzod avatar May 17 '17 08:05 bekzod

maybe also drop old IE support ?

How old do you think?

stefanpenner avatar May 17 '17 14:05 stefanpenner

below IE9 no ?

bekzod avatar May 17 '17 14:05 bekzod

can I take drop helpers on RSVP namespace... ?

bekzod avatar May 18 '17 09:05 bekzod

it is also good idea to drop option to pass promise to RSVP.filter because in others helpers RSVP.map and RSVP.filter you just pass array (you cannot pass promise), so it is not uniform

bekzod avatar May 18 '17 10:05 bekzod

can I take drop helpers on RSVP namespace... ?

sure, but we may need an upgrade transition path (so a quick guide, and maybe a compat shim) for some. At-least for ember users

stefanpenner avatar May 18 '17 14:05 stefanpenner

also adding .return(val) helper (alias to .then(()=> val)) would super helpful

bekzod avatar Jun 06 '17 17:06 bekzod

also adding .return(val) helper (alias to .then(()=> val)) would super helpful

I think i would prefer to have a second module, something like rsvp-party for such extra additions. Adding things to promise.prototype that isn't in the spec, or isn't destined for the spec is a tad risky IMHO.

stefanpenner avatar Jun 06 '17 21:06 stefanpenner

@stefanpenner when we will start merge for 4.0.0 :P ? maybe we just integrate compat shim to ember core and just deprecate stuff from there, and for others we can write up transition guide ? thoughts

bekzod avatar Jul 17 '17 08:07 bekzod

or we can move namespace changes and dropping things to 5.0.0, and in 4.0.0 drop es5 fallbacks, add reduce, add eager map/filter/reduce so it be seamless upgrade

bekzod avatar Jul 17 '17 09:07 bekzod

should we also drop rethrow not seeing it being used anywhere :P ?

bekzod avatar Jul 20 '17 04:07 bekzod