htmlbars icon indicating copy to clipboard operation
htmlbars copied to clipboard

[PERF] Don't Attempt To Sanitize Unsanitizeable

Open chadhietala opened this issue 10 years ago • 3 comments

This adds an identity check for falsy values before the value is sanitized. Currently we do work to sanitize things like undefined.

This is from a bench of a thousand link-tos Before: screen shot 2015-10-07 at 11 56 21 am

After: screen shot 2015-10-07 at 11 56 45 am

chadhietala avatar Oct 07 '15 19:10 chadhietala

such Unsanitiveable

stefanpenner avatar Oct 07 '15 19:10 stefanpenner

needs señor tests.

stefanpenner avatar Oct 07 '15 19:10 stefanpenner

Not really sure how to test this as the sanitization function is local. Not sure how helpful the test is.

chadhietala avatar Oct 09 '15 03:10 chadhietala