rust-prometheus icon indicating copy to clipboard operation
rust-prometheus copied to clipboard

Published 20 hours ago • verified publisher icon tikv

doc comments not matching with method return type

Open keepsimple1 opened this issue 3 years ago • 3 comments
trafficstars

https://github.com/tikv/rust-prometheus/blob/ac86a264223c8d918a43e739ca3c48bb4aaedb90/src/encoder/mod.rs#L19-L20

This method actually returns () if successful.

keepsimple1 avatar Jan 20 '22 23:01 keepsimple1

Great catch. Mind sending in a patch @keepsimple1?

mxinden avatar Jan 21 '22 09:01 mxinden

@mxinden please take a look at the linked PR when you have time? Thanks.

keepsimple1 avatar Jan 26 '22 19:01 keepsimple1

Unfortunately I no longer have permissions on this repository to e.g. approve CI to run. (Not complaining, this is fine, I haven't been involved much recently :heart:.)

Maybe @lucab can help?

mxinden avatar Jan 27 '22 11:01 mxinden