yardstick icon indicating copy to clipboard operation
yardstick copied to clipboard

poisson log loss function update

Open yonisidi opened this issue 1 year ago • 2 comments
trafficstars

The original code for the poisson_log_loss was taken from {MLmetrics} and it works well overall, but has some edge cases when Inf is returned

eg dpois(ypred, 0) = 0, dpois(ypred, 0, log = TRUE) = -Inf

taking the mean of a vector with that you get Inf

{MLmetrics} has since updated their function to be aligned with the standard entropy loss function, which resolves this edge case.

would it be possible to update the yardstick function to re-align with {MLmetrics}? see @example in the {MLmetrics} link

yonisidi avatar Jul 24 '24 13:07 yonisidi

Hello @yonisidi 👋

Sure would! I'll take a look next time to do a yardstick issue push

EmilHvitfeldt avatar Jul 25 '24 22:07 EmilHvitfeldt

awesome. ty

yonisidi avatar Jul 26 '24 12:07 yonisidi