titanium-sdk icon indicating copy to clipboard operation
titanium-sdk copied to clipboard

chore(android): remove aps-analytics.jar and titanium-verify.jar

Open m1ga opened this issue 1 year ago • 1 comments

Removed the aps-analytics.jar library and created the files locally. At a future point it should be removed. At the moment this should be the safest way to still have it without using the library.

Looks like titanium-verify.jar is also not needed anymore.

m1ga avatar Nov 24 '24 16:11 m1ga

We can remove the APS stuff as it's not required anymore with no Appcelerator Dashboard access around for its analytics. Also, we recently saw an ANR related to APSAnalytics initialisation.

prashantsaini1 avatar Feb 25 '25 07:02 prashantsaini1

Was marked as deprecated over 3 years ago in Ti 11.2.0 (https://github.com/tidev/titanium-sdk/commit/3e549242e8421601dc5f98bf68cb16e723bf7d27). Now we are two major versions further on.

Removing it with release of Ti 13.0.0 could have been the right moment. Should we now wait until next major release?

hbugdoll avatar Sep 28 '25 11:09 hbugdoll

The files are not use anymore. Just some methods e.g. in Ti.Platform:

public String getOstype()
	{
		return APSAnalyticsMeta.getOsType();
	}

call methods out of the classes. That's why I've kept the needed parts but just removed the jar files so we can reduce the code to needed methods.

m1ga avatar Sep 28 '25 11:09 m1ga

Just some methods e.g. in Ti.Platform:

public String getOstype()
	{
		return APSAnalyticsMeta.getOsType();
	}

call methods out of the classes.

Exactly! I was going to ask you about APSAnalyticsMeta and how to deal with it.

hbugdoll avatar Sep 28 '25 12:09 hbugdoll

we could also move those methods into another file but since it's not making any external connection I just kept the APS name and classes

m1ga avatar Sep 28 '25 12:09 m1ga

I just kept the APS name and classes

Ok.

The class attribute analyticsUrl can also be removed.

hbugdoll avatar Sep 28 '25 12:09 hbugdoll

I just kept the APS name and classes

Ok.

The class attribute analyticsUrl can also be removed.

thanks :+1: also removed

m1ga avatar Sep 28 '25 12:09 m1ga