community
community copied to clipboard
Rachio Update
New icon without white background, skip when nothing to report option, support device selection if you own multiple rachios, decide to show past and/or future events. Round timestamps to nearest 3 minutes -- this will allow the http cache, which has timestamps in the URLs, to leverage caching. Set to display full scroll, and option to adjust scroll speed.
@Matt-Pesce I made the changes we discussed, also went ahead and supported multiple devices (Should work, even though I only have a single device.. how about you?)
⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀
Next Steps
Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
- [ ] Sign the CLA if you haven't already
- [ ] Ensure your build is green! Any problem will display a proposed solution to try out
- [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer
Manual Review Required
Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
| Test | Details | |
|---|---|---|
| ✅ | App Dir | All files are in a single app directory |
| 🟡 | Modules | Usage of http.star requires review |
| 🟡 | Original Author | The original author (matthewfischer) does not match the PR author (rjison) |
@matthewfischer Cool to merge?
Yes this is much cleaner! Thanks
Also thanks @rjison