community icon indicating copy to clipboard operation
community copied to clipboard

Rachio Update

Open rjison opened this issue 1 year ago • 4 comments

New icon without white background, skip when nothing to report option, support device selection if you own multiple rachios, decide to show past and/or future events. Round timestamps to nearest 3 minutes -- this will allow the http cache, which has timestamps in the URLs, to leverage caching. Set to display full scroll, and option to adjust scroll speed.

@Matt-Pesce I made the changes we discussed, also went ahead and supported multiple devices (Should work, even though I only have a single device.. how about you?)

rjison avatar Oct 20 '24 04:10 rjison

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • [ ] Sign the CLA if you haven't already
  • [ ] Ensure your build is green! Any problem will display a proposed solution to try out
  • [ ] Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (matthewfischer) does not match the PR author (rjison)

tidbyt[bot] avatar Oct 20 '24 04:10 tidbyt[bot]

@matthewfischer Cool to merge?

matslina avatar Oct 21 '24 17:10 matslina

Yes this is much cleaner! Thanks

matthewfischer avatar Oct 21 '24 18:10 matthewfischer

Also thanks @rjison

matthewfischer avatar Oct 21 '24 19:10 matthewfischer