tidal-listener icon indicating copy to clipboard operation
tidal-listener copied to clipboard

Code highlight message structure typo

Open ndr-brt opened this issue 4 years ago • 3 comments

On the wiki it's reported that: < /code/highlight <duration> <cycle position> <row> <col> <row> <col>

but the reality is: < /code/highlight <duration> <cycle position> <col> <row> <col> <row>

In addition, row numbers start from 1 not from 0 as column numbers

ndr-brt avatar Jul 13 '21 15:07 ndr-brt

What do you think makes most sense -

to match with x y ?

yaxu avatar Jul 20 '21 10:07 yaxu

Note also this idea: https://github.com/tidalcycles/tidal-listener/issues/9

Designed to make it easier to implement highlighting that works even as code is edited, as individual characters can be associated with the original tokens as they are highlighted.

yaxu avatar Jul 20 '21 10:07 yaxu

The best would be to match x y and make them starts from zero.

ndr-brt avatar Jul 21 '21 15:07 ndr-brt