KernelSU icon indicating copy to clipboard operation
KernelSU copied to clipboard

manager: module: refresh after action button action

Open backslashxx opened this issue 1 year ago • 5 comments

Please check before submitting an issue

  • [X] I have searched the issues and haven't found anything relevant
  • [X] I will upload bugreport file in KernelSU Manager - Settings - Report log
  • [X] I know how to reproduce the issue which may not be specific to my device

Describe the bug

user has to pull down to refresh after action button action some modules use description ie on module.prop to show status

To Reproduce

https://github.com/backslashxx/bindhosts/blob/4e7ba03e0576b0e0bceac5c1ba4f1d2f3260814c/action.sh#L98

  • this part where description gets updated

Screenshots

https://github.com/user-attachments/assets/685cfedc-3649-4bab-ae98-9e2126a1744a

Expected behavior

Module manager refreshes itself

https://github.com/user-attachments/assets/7e76bbc5-dee5-441f-9d60-a99c5e29359e

Logs

irrelevant

Device info

  • Device: irrelevant
  • OS Version: A14 QPR3
  • KernelSU Version: 11985 (reverted for < 5.2 )
  • Kernel Version: irrelevant https://github.com/backslashxx/KernelSU

Additional context

No response

backslashxx avatar Oct 31 '24 01:10 backslashxx

Maybe creating a refresh function after action button was pressed is a good idea.

rsuntk avatar Oct 31 '24 02:10 rsuntk

Maybe creating a refresh function after action button was pressed is a good idea.

it gets refreshed on module updates/customize.sh triggers but not on action ofcourse this is also on downstream, Apatch magisk behavior refreshes it auto as seen on top

ig i'll tag this guy https://github.com/tiann/KernelSU/pull/2156

backslashxx avatar Oct 31 '24 03:10 backslashxx

it gets refreshed on module updates/customize.sh triggers but not on action ofcourse this is also on downstream, Apatch

Apatch refreshed by default?

rsuntk avatar Oct 31 '24 03:10 rsuntk

@rsuntk

https://github.com/user-attachments/assets/19cf0079-dd1c-4ad3-be2f-0d8be9df4c69

seems same bug on Apatch maybe thats where I should report this as the change came from them according to #2156

backslashxx avatar Oct 31 '24 16:10 backslashxx

Modify onBack function maybe can fix it

rsuntk avatar Oct 31 '24 23:10 rsuntk