sqlmodel
sqlmodel copied to clipboard
π¨βπ» Compilation of Pull Requests
Below I will place the links to the pull requests that I think should be accepted and the links to the comments where I explain why.
- [x] https://github.com/tiangolo/sqlmodel/pull/322
- In this PR (https://github.com/leynier/sqlmodel/pull/37) pointing to a fork, you can see that the tests are successful. I think that It is not necessary to add extra tests for this PR because the existing tests validate the change since without the change of this PR the tests fail. Source
Codecov Report
Merging #389 (437eadd) into main (4d20051) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #389 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 181 181
Lines 6037 6038 +1
=======================================
+ Hits 5886 5887 +1
Misses 151 151
| Impacted Files | Coverage Ξ | |
|---|---|---|
| sqlmodel/main.py | 81.79% <100.00%> (+0.05%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update 4d20051...437eadd. Read the comment docs.
π Docs preview for commit 437eadde55b77186185cd6f369cf1a1fde4075e2 at: https://62e64124a8681632b51209e6--sqlmodel.netlify.app
Thanks @leynier! As these PRs are already merged, I'll close this one. Thanks for the interest and help! :cake: