thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Taglines do not work for anonymous instances

Open micahmo opened this issue 1 year ago • 6 comments

Description

I discovered a couple of new issues with taglines. I'm not sure if these go back to the feed refactor or something else.

  • [x] Opening the FAB causes the tagline to refresh many times during the animation.
    • I remember having a similar issue when first adding taglines, and the solution was to fetch the random tagline once when loading the feed, rather than during the build. If it's done during the build, then any time the feed rebuilds, the tagline can change. I see now it's fetched directly in the TagLine widget, so I'm not sure how best to fix it.
  • [ ] Taglines don't work for anonymous instances (note that it will work if you switch from an account to anonymous; you have to restart the app in anonymous mode).

Screenshots

Demo of first issue

https://github.com/thunder-app/thunder/assets/7417301/58fa66ce-b5a1-4cfe-9278-bc34b4f2d7d5

micahmo avatar Dec 06 '23 04:12 micahmo

@micahmo is this issue still open ?? if yes i would like to give it a try

Niranjan-Dorage avatar Jan 12 '24 04:01 Niranjan-Dorage

Yes it is, go for it!

micahmo avatar Jan 12 '24 04:01 micahmo

@micahmo ok

Niranjan-Dorage avatar Jan 12 '24 04:01 Niranjan-Dorage

Can this be closed?

CTalvio avatar May 02 '24 14:05 CTalvio

I believe taglines still don't work for anonymous instances.

micahmo avatar May 02 '24 14:05 micahmo

Ah, they don't. You could change the title to that specifically now that the other thing is fixed.

CTalvio avatar May 02 '24 16:05 CTalvio