thunder
thunder copied to clipboard
Taglines do not work for anonymous instances
Description
I discovered a couple of new issues with taglines. I'm not sure if these go back to the feed refactor or something else.
- [x] Opening the FAB causes the tagline to refresh many times during the animation.
- I remember having a similar issue when first adding taglines, and the solution was to fetch the random tagline once when loading the feed, rather than during the build. If it's done during the build, then any time the feed rebuilds, the tagline can change. I see now it's fetched directly in the
TagLinewidget, so I'm not sure how best to fix it.
- I remember having a similar issue when first adding taglines, and the solution was to fetch the random tagline once when loading the feed, rather than during the build. If it's done during the build, then any time the feed rebuilds, the tagline can change. I see now it's fetched directly in the
- [ ] Taglines don't work for anonymous instances (note that it will work if you switch from an account to anonymous; you have to restart the app in anonymous mode).
Screenshots
Demo of first issue
https://github.com/thunder-app/thunder/assets/7417301/58fa66ce-b5a1-4cfe-9278-bc34b4f2d7d5
@micahmo is this issue still open ?? if yes i would like to give it a try
Yes it is, go for it!
@micahmo ok
Can this be closed?
I believe taglines still don't work for anonymous instances.
Ah, they don't. You could change the title to that specifically now that the other thing is fixed.