thunder
thunder copied to clipboard
Add video player
Currently embedded videos are not being shown and indicate error Please add ability to view videos in the posts
This would be very cool.
https://pub.dev/packages/video_player
This feature is sorely needed for Peertube content. Currently, peertube content is displayed as a link to the video rather than the video itself. An example of this would be this Peertube channel federated to Lemmy. As mentioned by @Nutomic, the Lemmy backend supports video embeds, so this should be able to be implemented in Thunder.
@ggichure I've marked this issue as in progress since you were experimenting with video support in #1081. Of course you're not obligated to continue for any reason, so let us know if there are any updates or if we should remove the status.
@micahmo Leave the status. I'll have sometime coming week to complete it.
Marking this as completed!
Peertube content appears to still not have a video player. For example, the channel that I mentioned in this comment, https://github.com/thunder-app/thunder/issues/383#issuecomment-1869753224, doesn't have a video player.
This issue is more-so for the general video player while #1009 is tracking support for Peertube videos (which is still open)!
Ha, my bad! I forgot that I had created that issue.
Marking this as completed!
Brilliant, I tried invidious videos with direct play in post, but no luck, probly the same problem with PeerTube functionality
Feel free to provide links to any examples you tried so we can track them for testing!