thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Add video player

Open kovalensky opened this issue 2 years ago • 5 comments

Currently embedded videos are not being shown and indicate error Please add ability to view videos in the posts

photo_2023-07-16_22-19-57

kovalensky avatar Jul 16 '23 18:07 kovalensky

This would be very cool.

CTalvio avatar Jul 16 '23 20:07 CTalvio

https://pub.dev/packages/video_player

CTalvio avatar Jul 31 '23 17:07 CTalvio

This feature is sorely needed for Peertube content. Currently, peertube content is displayed as a link to the video rather than the video itself. An example of this would be this Peertube channel federated to Lemmy. As mentioned by @Nutomic, the Lemmy backend supports video embeds, so this should be able to be implemented in Thunder.

K4LCIFER avatar Dec 26 '23 20:12 K4LCIFER

@ggichure I've marked this issue as in progress since you were experimenting with video support in #1081. Of course you're not obligated to continue for any reason, so let us know if there are any updates or if we should remove the status.

micahmo avatar Apr 11 '24 19:04 micahmo

@micahmo Leave the status. I'll have sometime coming week to complete it.

ggichure avatar Apr 12 '24 08:04 ggichure

Marking this as completed!

hjiangsu avatar Jun 05 '24 17:06 hjiangsu

Peertube content appears to still not have a video player. For example, the channel that I mentioned in this comment, https://github.com/thunder-app/thunder/issues/383#issuecomment-1869753224, doesn't have a video player.

K4LCIFER avatar Jun 05 '24 21:06 K4LCIFER

This issue is more-so for the general video player while #1009 is tracking support for Peertube videos (which is still open)!

hjiangsu avatar Jun 05 '24 22:06 hjiangsu

Ha, my bad! I forgot that I had created that issue.

K4LCIFER avatar Jun 05 '24 23:06 K4LCIFER

Marking this as completed!

Brilliant, I tried invidious videos with direct play in post, but no luck, probly the same problem with PeerTube functionality

kovalensky avatar Jun 06 '24 04:06 kovalensky

Feel free to provide links to any examples you tried so we can track them for testing!

micahmo avatar Jun 06 '24 12:06 micahmo