app-remote-protocol icon indicating copy to clipboard operation
app-remote-protocol copied to clipboard

Add message field to quote model

Open dbrgn opened this issue 5 years ago • 3 comments

The message needs to be embedded, since the webclient might not have received that message yet.

dbrgn avatar Jan 27 '20 15:01 dbrgn

Also, have you checked for side effects? This model is being used throughout a couple of other messages and I'm not sure it makes a lot of sense in all of them.

lgrahl avatar Jan 28 '20 09:01 lgrahl

Also, have you checked for side effects? This model is being used throughout a couple of other messages and I'm not sure it makes a lot of sense in all of them.

What type of side effects would you expect? All new fields are optional, so the protocol change itself will not break anything, unless it's explicitly handled.

You're right though that creating a quote and retrieving a quote could use separate types (Quote and NewQuote, since when creating a quote the remote client would not send along the message, only the message ID). The downside of a separate type would be that we lose backwards compatibility (since the NewQuote type would probably not include the quoted text).

dbrgn avatar Jan 28 '20 16:01 dbrgn

@lgrahl I added some additional notes regarding validation.

dbrgn avatar Jan 28 '20 17:01 dbrgn