build-your-own-radar
build-your-own-radar copied to clipboard
thoughtworks
feature: add optional support for moved in / out blips
Hot on the heels of the v1.0.0 launch this week, I thought I'd see whether I could self-serve #177
Adds optional support for moved in and out blip drawing.
Below are two datasets for Thoughtworks Volume 27 sample (csv) that can be used to demonstrate/test:
@devansh-sharma-tw @naveengenupuritw - appreciate your feedback re this feature proposal
Thanks for raising this @setchy ! We're internally discussing on adding the moved in/out status as well (to keep BYOR inline with our Thoughtworks Radar). This PR helps a lot for this and we'll update here soon regarding the feature. Thanks!
@devansh-sharma-tw - hope all is well. Just checking in to see if your team has had a chance to review and consider this PR.
@marisahoenig - I have updated this PR to support a new, optional column/field called status.
Accepted values are case-insensitive new, no change, moved in, moved out. I welcome any feedback on alternate option names (eg: existing or unchanged etc)
To demonstrate, I've updated my TW volume datasets, eg TW Volume 28.
All existing datasets using isNew should continue to work.
[!NOTE] In the interim I've deployed my BYOR enhancements @ https://radar.setchy.io, which bring it up to the functionality found on https://thoughtworks.com/radar
Hey @setchy I left a few comments. Please resolve and also make sure the most recent code from the main branch of this repo is loaded in. I'll chat with the team next week to see if we can get this added. The slowdown was related to the most recent Radar release, and we need to make sure changes like this are reflected on our live site as well. Apologies for the delay — it's a great add to the tool.
Thanks @marisahoenig, appreciate the feedback. I've gone through and addressed each of them 😄.
No problems about the delay, too - completely understand.
Thank you @shiviraj @marisahoenig @will-amaral - what a great gift for a Thursday morning 🙏