learned-sparse-retrieval icon indicating copy to clipboard operation
learned-sparse-retrieval copied to clipboard

Enable pip install?

Open eugene-yang opened this issue 1 year ago • 5 comments

I'm wondering are you planning to add a setup.py to allow pip install? I could draft one if you want :)

eugene-yang avatar Apr 16 '24 17:04 eugene-yang

This would be nice! I'm happy to help test/draft it.

andrewyates avatar Apr 18 '24 10:04 andrewyates

I'm not too familiar with Hydra, but is there a way to reference a yaml file outside of the package directory? If we want to make this a package, not requiring people to modify the content of the package when extending to other models/experiments would be a better workflow.

eugene-yang avatar Apr 22 '24 22:04 eugene-yang

I think you can use --config-dir <dir> to add an additional directory to the search path.

andrewyates avatar Apr 23 '24 14:04 andrewyates

would it be more convenient to provide method to train without yaml file config?

thongnt99 avatar Apr 24 '24 23:04 thongnt99

I would say maybe... depends on what use cases you imagine people would be adapting this framework to.

The current setup makes it very easy to replicate experiments and adapt the code to new data, but more complicated to modify the code or inherit the classes. The latter is making this framework more like a toolkit (e.g. huggingface transformers). I certainly like to use it like a toolkit but it really depends on where you imagine this repository is heading to.

eugene-yang avatar Apr 29 '24 02:04 eugene-yang