diffparser icon indicating copy to clipboard operation
diffparser copied to clipboard

Published 20 hours ago • verified publisher icon thombergs

Handle incomplete lines

Open detouched opened this issue 7 years ago • 0 comments

Sorry for a bit of a mess, there seems no way to make a cross-repo stacked pull request on GitHub, so this PR also contains a commit form my previous PR. Please either review and merge the other one first, so that this one becomes smaller, or just review the second commit here. Please advise if there's a better way to organise this.

There're two changes in the second commit:

  • Incomplete marker lines are not parsed as NEUTRAL lines anymore, they are set as a flag on a Diff for either of the diff side instead. This is a potentially breaking change, so version bumped to 2.0.

  • TestNG used to pull in JUnit as a direct dependency, and test classes used to use a mixture of TestNG and JUnit assertions. This commit bumps TestNG to a recent 6.14.3 which doesn't have JUnit anymore, and adjusts the tests to use TestNG assertions only.

detouched avatar Jun 07 '18 02:06 detouched