Stealth: Missing Reviews

[cookiengineer]

The request/*.mjs Modules need reviews.

• [x] Implement Blocker.check
• [ ] Implement Downloader.check
• [ ] Implement Downloader.download
• [ ] Implement Optimizer.check
• [ ] Implement Optimizer.optimize

Additionally, the following Core Implementations need reviews, too:

• [x] stealth/Browser
• [ ] stealth/Request
• [x] stealth/Session
• [x] stealth/Settings
• [x] stealth/Tab

[cookiengineer]

As of https://github.com/cookiengineer/stealth/commit/9091744ee5941948c3488ed4f14ddf086f974473 most of the core functionality is now tested end-to-end, including the Request API.

As Covert meanwhile uses the check action to verify the contents of a Review against its Implementation, the test coverage got pretty high.

Some Network Protocols have still to be tested, in particular:

stealth/protocol/HTTP:

• [x] HTTP.upgrade()

stealth/protocol/HTTPS:

• [ ] HTTPS.upgrade()

stealth/protocol/WS:

• [x] WS.receive()
• [x] WS.upgrade()

stealth/protocol/WSS:

• [ ] WSS.upgrade()
• [x] WSS.receive()

Currently, I have no idea how to implement those tests, as all of them are quite complicated in their handled network states and asynchronous interactions with them on the counter-part.

[cookiengineer]

The Session service needs further Reviews once the integration with the UI cards has been implemented.

So far, these were the newly added methods to stealth/server/Session and stealth/client/Session:

• [ ] Session.remove()

[cookiengineer]

The Blockers service has changed now, too, and needs a better Review.

• [ ] Fix Settings Review
• [ ] Fix Settings Service Reviews (client/server)
• [ ] Fix Blocker Service Review (client/server)