solid-dnd icon indicating copy to clipboard operation
solid-dnd copied to clipboard

Issue with Multiple Lists example.

Open ivanjeremic opened this issue 3 years ago • 5 comments

I need to work with multiple lists in my project so I started out by copy pasting the Multiple List example from the website in my CodeSanbox to get familiar with it, the code in untouched I really changed nothing except added some inline styles for better visibility.

The issue is that the dnd is not working properly, dragging items from one to the other Column is working mostly only the first time and dragging all in to one almost never and generally it stops working properly after first drag. I'm confused and asking myself now is this really an issue with the way I try to test this maybe a style issue, or maybe something with example itself?

https://codesandbox.io/s/solid-multiple-dnd-4b7n4l?file=/src/main.tsx

ivanjeremic avatar Jun 08 '22 17:06 ivanjeremic

Yeah I can confirm that it's an issue, even with the original styles see here https://stackblitz.com/edit/vitejs-vite-mgwbtc?file=src/App.tsx.

m4rvr avatar Jun 10 '22 07:06 m4rvr

I think this is to do with a change in Solid JS itself that is backwards incompatible. Will dig more.

martinpengellyphillips avatar Jun 10 '22 13:06 martinpengellyphillips

Yep - this started being an issue with the move from solid-js 1.3.17 to 1.4.x.

martinpengellyphillips avatar Jun 10 '22 13:06 martinpengellyphillips

Yep - this started being an issue with the move from solid-js 1.3.17 to 1.4.x.

Will this be fixed in the rewrite of this library or can we expect some bugfix for it sooner?

ivanjeremic avatar Jul 23 '22 16:07 ivanjeremic

I think as part of the refactor (not rewrite!) is more realistic expectation. But if someone wants to propose a pr with a fix for current version then I'll happily review it for merge and release.

martinpengellyphillips avatar Jul 26 '22 11:07 martinpengellyphillips

Hi @martinpengellyphillips Is there any kind of a timeline for when this should be fixed, or is this being worked on? My team would work on fixing it as we are using solid-dnd, and our drag-and-drop is broken in some places because of this issue. Thanks!

Zachiah avatar Sep 07 '22 15:09 Zachiah

I've got a working local branch with SolidJS 1.5 and I'd expect to release that in the next week alongside other changes.

martinpengellyphillips avatar Sep 07 '22 16:09 martinpengellyphillips

This is now addressed in 0.7.0 which now supports Solid JS 1.5+

martinpengellyphillips avatar Sep 07 '22 21:09 martinpengellyphillips