Scott Lahteine

Results 437 comments of Scott Lahteine
trafficstars

The `viewer_asymmetric_range` flag is still referenced, so that cannot be removed just yet. If it is no longer relevant then the code that refers to it must be updated. Check...

> I didn't see what was wrong with the thumbnail preview. @mriscoc — If you look at the current `bugfix-2.1.x` code you will see that `viewer_asymmetric_range` exists as part of...

The general problem remains that G-code commands only supply a single feed rate in terms of current units per second, but not all axes have a meaningful conversion from degrees...

> Indeed, I would say that https://github.com/MarlinFirmware/Marlin/pull/24334 is the more complete solution regarding the feedrate for linear moves vs. rotation. I have not tested that PR in a while but...

> Still not sure if the PWM_PIN change should remain. It's nice to have when setting up a new board but of no use to the average user. We can...

Thanks for the submission of the code in its raw form. Obviously this will require some weeks of cleanup before it will be suitable for merging into our carefully curated...

Is there something that you wanted to add in relation to the new environment for STM32H753ZI? It might be better to hold the changes adding that environment until there's a...

This PR is well out of date so it's probably best to close it and start with a fresh PR after you've had a chance to rebase your working branch...

It may be better for you to get involved with #25631 rather than bringing a new set of at-odds PRs into the mix. Please join the conversation there and we'll...

Everything looks good to me! I moved the new config options to the same section as the other serial ports, removed the need to define `RS485_ENABLED` (just looks for the...