angular-medium-editor icon indicating copy to clipboard operation
angular-medium-editor copied to clipboard

Created a factory to properly inject MediumEditor.

Open austinthedeveloper opened this issue 9 years ago • 2 comments

In certain circumstances, jshint will throw an error in applications where a plugin has not been declared correctly in Angular. When it is injected as a factory and called when needed, jshint will stop throwing that error.

This solution is based from this Stack Overflow question about injecting jQuery and underscore:

http://stackoverflow.com/questions/17408977/inject-jquery-and-underscore-to-angular-js-component

austinthedeveloper avatar May 02 '16 19:05 austinthedeveloper

Thanks for this PR, has anybody time to look into this, @simison ?

thijsw avatar Aug 09 '16 12:08 thijsw

Very low on time right now, but LGTM (tho I didn't test this).

I also think Factory is the right way to inject external libraries. :thumbsup:

simison avatar Aug 09 '16 13:08 simison