python-tuf icon indicating copy to clipboard operation
python-tuf copied to clipboard

SimpleEnvelope._DEFAULT_PAYLOAD_TYPE should be public?

Open jku opened this issue 1 year ago • 1 comments

ngclient accesses SimpleEnvelope._DEFAULT_PAYLOAD_TYPE.

flake8-self linter complains about this, I think correctly. If we use the value from a different module, it should be public

CC @lukpueh for comment

jku avatar Apr 03 '24 12:04 jku

I suppose I didn't see a reason to expose it to every user of the API. But flake8 is right, that ngclient is also just a user of that API. I'm with with making the variable public.

lukpueh avatar Apr 03 '24 12:04 lukpueh

Hi, I would like to work on it. I will create PR. Thank you 👍

h4l0gen avatar May 28 '24 00:05 h4l0gen