python-tuf icon indicating copy to clipboard operation
python-tuf copied to clipboard

GitHub Actions: Find and implement fail-fast strategy

Open lukpueh opened this issue 4 years ago • 1 comments

Description of issue or feature request:

#1242 added a GitHub Actions based CI workflow, which runs all configured builds in parallel, ignoring each others build results. However, GitHub Actions provides an option (i.e. fail-fast), to abort all builds if any build fails. This option might be useful for specific build relationships, where one failing build is likely to entail other failing builds.

Current behavior: fail-fast: false

Expected behavior: Consider fail-fast: true (default) but with specific conditions, e.g. prioritize lint build and abort any other build if that one fails.

lukpueh avatar Dec 17 '20 11:12 lukpueh

Another way to do this would be to make lint and test builds different jobs and configure needs: [<lint job>] on the test job.

lukpueh avatar Jan 12 '21 12:01 lukpueh

I have made some changes in the GitHub actions file to achieve the below intentions.

  1. Run the lint job as the first job in the matrix.
  2. Fail all of the follow-up jobs if lint fails.
  3. Allow failure of other jobs is lint passed.

Please review the PR. Thanks.

shabeebk avatar Feb 05 '23 22:02 shabeebk