go-tuf CI runs on simulated merge commit, but leaves comments on unmerged code

CI runs on simulated merge commit, but leaves comments on unmerged code

Open ethan-lowman-dd opened this issue 3 years ago • 5 comments

CI appears to run on a simulated merge commit, such as this one for this PR. This is useful, since it verifies that the build will remain green upon merge, but it results in confusing test output and PR comments from GitHub actions, such as the following. These errors do not correspond with the code around the comments on the PR, but rather the code in the simulated merge commit.

Mar 27 '22 00:03 ethan-lowman-dd

Yeah, I was confused, too. How do we fix this?

Mar 27 '22 10:03 trishankatdatadog

One way would be to run tests on the branch itself (not a merge commit) but set up a merge queue to re-run CI on the simulated merge commit before the merge completes.

Mar 27 '22 17:03 ethan-lowman-dd

@rdimitrov do you think you could take a look at this?

Mar 28 '22 08:03 joshuagl

@ethan-lowman-dd can you help us reproduce the results in your screenshot? The PR and merge commit you linked to don't show any Check failures here as we haven't merged the CI changes yet.

Mar 29 '22 10:03 joshuagl

Here is the CI run that failed: https://github.com/theupdateframework/go-tuf/actions/runs/2046098449

Mar 30 '22 20:03 ethan-lowman-dd

Closing since the code base changed and so it is no longer relevant

Thanks for raising this 👍

Jan 31 '24 21:01 rdimitrov

go-tuf go-tuf copied to clipboard

CI runs on simulated merge commit, but leaves comments on unmerged code

go-tuf
go-tuf copied to clipboard