flysystem icon indicating copy to clipboard operation
flysystem copied to clipboard

Abandoned Azure Storage Adapter

Open pimjansen opened this issue 1 year ago • 8 comments

Hey,

Since march 2024, Microsoft pulled support from their storage SDK (for PHP). https://github.com/azure/azure-storage-php

The Flysystem Azure Adapter is still using the blob adapter which is no longer supported. Together with a small team we set up azure-oss instead to overcome this issue and created a new version for the blob api at: https://github.com/Azure-OSS/azure-storage-php.

Today we tested the flysystem adapter with the new storage sdk with a 100% pass on all the tests (so we are ready to release).

I was wondering what you want, should we bump the storage adapter in the flysystem repo to match the new open sdk or should we create a new flysystem adapter?

The first one would be my initial suggestion but that depends on future and ideas etc. At this moment it is just matter of time and the adapter will no longer function.

pimjansen avatar Jul 03 '24 14:07 pimjansen

Hi @pimjansen, great to see the community step in. I'm more in favour of adding a new adapter named, league/flysystem-azure-oss and deprecate the old one. Primary reason is to force people to make the conscious choice to adopt a new underlying vendor. Too many recent incidents in the wider OSS community of vendor switches failing, so I think it's a sound default to take.

frankdejonge avatar Jul 03 '24 15:07 frankdejonge

I'll make a copy tonight and make sure it is released in all the channels.

frankdejonge avatar Jul 03 '24 15:07 frankdejonge

I'll make a copy tonight and make sure it is released in all the channels.

Great! We did not tag the release yet but will as soon as possible. So maybe a better idea to wait until we push the 1.0 and go from there?

We still have todo some small stuff on the sdk and handle some of the docs.

But glad you are open for change! Maybe also a good idea for a suggests?

pimjansen avatar Jul 03 '24 17:07 pimjansen

We still have some work left to be feature complete with the old version:

  • optional prefix
  • optional throw or ignore on setting visibility

And bonus

  • temporary urls

I will give you a heads up if it's ready.

brecht-vermeersch avatar Jul 03 '24 18:07 brecht-vermeersch

@frankdejonge we have a working adapter here: https://github.com/Azure-OSS/flysystem-azure-storage-blob

You want to link this one or want to include it in the flysystem organisation? Both is fine for us ofc but id we keep it where it is we have to renamed some stuff first.

We will also include flysystem in the docs to push as much people to that direction (for simplicity)

pimjansen avatar Jul 06 '24 20:07 pimjansen

@frankdejonge had time to look at this?

pimjansen avatar Jul 17 '24 07:07 pimjansen

This looks really interesting. If I wanted to use the new storage adapter in a Symfony project, would it have to be added to flysystem-bundle?

cancan101 avatar Aug 05 '24 17:08 cancan101

@pimjansen Hi pim, sorry for the delay on this. Happy to accept a PR to link to your adapter in the documentation 👍

frankdejonge avatar Dec 10 '24 19:12 frankdejonge