pgtap icon indicating copy to clipboard operation
pgtap copied to clipboard

Switch plan(int) to plan(bigint)

Open jnasbyupgrade opened this issue 7 months ago • 4 comments
trafficstars

A useful test pattern is to define a matrix of tests in a table or view by building a cartesian join of multiple dimensions. If you do that, you'll want to do something along the lines of

SELECT plan( 0

  • (SELECT count(*) FROM test_view) );

Because count() returns bigint doing this with plan(int) forces you to cast the output of count() to int. Switching plan() to accept a bigint removes the need for that cast.

jnasbyupgrade avatar Apr 18 '25 19:04 jnasbyupgrade

@theory shouldn't this PR have kicked off an automated test run?

jnasbyupgrade avatar Apr 18 '25 19:04 jnasbyupgrade

It would have if you didn't keep changing your damn GitHub account name, @jnasbyupgrade! Is this who you are now? Currently the collaborators are:

image

theory avatar Apr 18 '25 20:04 theory

Ahh, didn't realize tests were limited to contributors. You can remove nasbyj since I no longer work at Amazon. This is my new work account. I can also just do things from my personal account if you'd rather that.

jnasbyupgrade avatar May 19 '25 19:05 jnasbyupgrade

Whichever you prefer. Maybe if @jnasbyupgrade is another work account it should be your personal account? @decibel already had the permissions.

theory avatar May 19 '25 19:05 theory