go-heaps icon indicating copy to clipboard operation
go-heaps copied to clipboard

fix maxBucketSize

Open zhiqiangxu opened this issue 5 years ago • 2 comments

This PR tries to make maxBucketSize more close to (log n) + 1.

i.e, it returns 1 for size 1, returns 2 for size 2,3, returns 3 for size 4,5,6,7 etc.

zhiqiangxu avatar Dec 21 '19 13:12 zhiqiangxu

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files           7        7           
  Lines         728      728           
=======================================
  Hits          622      622           
  Misses         78       78           
  Partials       28       28
Impacted Files Coverage Δ
rank_pairing/rank_pairing_heap.go 83.73% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88e3535...e52c692. Read the comment docs.

codecov-io avatar Dec 21 '19 13:12 codecov-io

@theodesp Could you help verify this PR?

zhiqiangxu avatar Dec 22 '19 03:12 zhiqiangxu