simulacrum
simulacrum copied to clipboard
`createSimulation` auth0 `client_id` vs `clientId`
trafficstars
createSimulation expects a clientId, but it seems there is prior art to client_id and we may want to consider migrating.
the auth0 config uses client_id and it is a source of bugs (I've done it) by passing in clientId and not client_id. I think I would rename ours to client_id and be done with it.
reference: https://github.com/thefrontside/simulacrum/pull/114#discussion_r691035835
I think we need better typing around config in general
export interface SimulationOptions {
options?: Record<string, unknown>;
services?: Record<string, {
port?: number;
}>
}
options?: Record<string, unknown> does not offer much to keep someone on the straight and narrow