ansible-letsencrypt icon indicating copy to clipboard operation
ansible-letsencrypt copied to clipboard

Published 20 hours ago • verified publisher icon thefinn93

virtualenv conditional

Open thefinn93 opened this issue 9 years ago • 6 comments

Installation of the virtualenv package doesn't work on older OSs (older than Debian jessie or Ubuntu Vivid), but on newer OSs need it over python-virtualenv (see #6). We should improve the conditional to reflect this nuance.

thefinn93 avatar Jan 20 '16 17:01 thefinn93

I'd like to get this role working on Ubuntu 14.04. Would https://github.com/pmackay/ansible-letsencrypt/commit/e47e38914856b6e3e67fe29ec87b06b6423b9947 be ok to do a PR? Not sure if this generalizes the solution enough though.

pmackay avatar Jun 01 '16 17:06 pmackay

eh i guess. Not ideal but whatever. Maybe someone will come along and fix it all one day...

thefinn93 avatar Jun 02 '16 04:06 thefinn93

Do you happen to know of any matrix that lists all the distributions and versions? And a simple way to determine the right package for each? Or is it a case of trial and error testing or looking up for each one?

pmackay avatar Jun 02 '16 06:06 pmackay

I've done a more generalized approach here https://github.com/pmackay/ansible-letsencrypt/commit/f0d33e7fdfdce2e668bfb0fa8bae5c7e8264a4dc. Does that seem OK?

Have also created a travis-test branch that sets up testing the role on Travis, which I could also raise a PR for if that sounds useful?

pmackay avatar Jun 02 '16 08:06 pmackay

PR the travis branch for sure! I'm wrapping of my last quarter of university so I'm gonna be focusing on finals for a bit, I'll take a look at the other thing sometime next week

thefinn93 avatar Jun 02 '16 23:06 thefinn93

Have created #34, feedback welcome whenever is convenient.

pmackay avatar Jun 03 '16 16:06 pmackay