Anthony Dodd

Results 219 comments of Anthony Dodd

@idanarye re async-trait: true, true. I'm wondering if that would be viable for now. As far as references, I should have been more clear with what I said. I was...

> `#[await]` was never stable and stable Hmm, I never said it was. My point has clearly been missed, but that's ok. Your response about `ActorFuture` is pertinent, so I'll...

@idanarye what if we use a signature like the following instead (`&self` instead of `&mut self`) : ```rust impl Handler for Foo { type Result = ...; async fn handle(&self,...

To be sure, in case it isn't clear from the above, doing so would allow us to remove the `ActorFuture` construct. - every message handler would only take a shared...

Would it? I'm not sure. I'm definitely just spitballing on design ideas and such. - state & functionality would still be encapsulated within each actor. - functionality would still be...

Based on a quick look through the code, it looks like per actor: - all `wait` futures are polled to completion first. - then the mailbox is drained. - then...

Hey @skletsun , thanks for the report. Sounds like this could be an issue with the RaftStorage implementation. Are you using your own implementation? The thing which makes me say...

@skletsun hey boss. Sorry for the late response here. I did some mental review of the code based on our discussion here, and if you take a look at the...

@shikhar ah yes. I agree. I remember some discussion about implementing a few of these optimizations a while back. This is a great idea. We should absolutely implement these optimizations...

Hey folks! Thanks for the feedback and thoughts here. I definitely want to get this in place before we ship the 1.0.