voyager Issue 2985 - Forgot Password Functionality

Adds the ability to request a password reset for Voyager users as requested in #2985

The email template might want customising as it uses the standard Laravel one for the time being.

There may also be some language strings that I have missed but have a scout around and get back to me.

Jul 17 '18 18:07 andrewnclark

Builds 5 and 6 both have the following issue and I'm not sure why - any help would be appreciated.

There was 1 failure:
1) TCG\Voyager\Tests\DatabaseTest::test_can_update_table
Failed asserting that true is false.
/home/travis/build/the-control-group/voyager/tests/DatabaseTest.php:243
/home/travis/build/the-control-group/voyager/tests/DatabaseTest.php:96

Jul 17 '18 21:07 andrewnclark

Hopefully this will be of interest to the folks who took part in #300

Jul 17 '18 22:07 andrewnclark

Very useful, I have tested and it's great!!. It would be useful to show a message at the end, notifying to the user that an email was sent for the password reset. +1

Aug 13 '18 00:08 skarjoss

Thanks for the feedback @oscarquinde I'll add that notification this week sometime! Could be this evening to be fair.

Aug 13 '18 12:08 andrewnclark

@oscarquinde - Took me a little longer than I had planned but I've added a notification to the user as requested.

Aug 16 '18 21:08 andrewnclark

Any feedback here? Is it being held up due to the lack of tests or something else?

Sep 27 '18 13:09 andrewnclark

It's not being held up for any particular reason. We just haven't had a chance to review it ourselves yet

Oct 01 '18 18:10 fletch3555

Cheers @fletch3555

I'll leave it in your hands and wait for any feedback.

Oct 04 '18 15:10 andrewnclark

I think this is a basic feature for admin panel, and should be available by default on voyager considering it has reached 1.0 version. I hope it will be available soon even without pr.

Feb 02 '19 07:02 dexcell

Waiting on a response to @emptynick's requests

May 22 '19 04:05 fletch3555

why the forgot password feature is still not available, why the PR is not merged @fletch3555 ?

Oct 21 '19 07:10 Haritsinh

Because there are changes requested as you can see above.

Oct 21 '19 07:10 emptynick

Because there are changes requested as you can see above.

sorry for the inconvenience, i have seen in files changed tab in that you have suggested to remove config and translating the English literal string to translatable, only these 2 changes or any other changes are also requested? because i am newbie in this type of contribution and i have not contributed much but if you can explain then i want to contribute in this project because i love the easiness the voyager has brought in environment.

Oct 21 '19 11:10 Haritsinh

Isn't there anyone who can add this major functionality?