zoo icon indicating copy to clipboard operation
zoo copied to clipboard

Implement lane-wise modulo.

Open jamierpond opened this issue 1 year ago • 2 comments

No safety about the subtract one, but shouldn't be an issue if your values are in range.

Depends on the "ergonomics" PR, which should merge first, and then the "base" of this PR should be moved to master.

jamierpond avatar May 26 '24 07:05 jamierpond

I have repeatedly expressed that accidental indentation levels are contrary to the principles of how the sources ought to express more detail. Besides, they have the practical effect of shifting the important part of the source code to the right, and an incentive to damage the code with wider lines.

thecppzoo avatar May 27 '24 01:05 thecppzoo

The implementation look good. I have a problem with the unit tests. Not even with what is tested, that seems right, but how things are tested, however semantically correct, they are misuse of the available operations. A user attempting to use this operations with elegance and top performance would be more confused by these tests than without these tests. That users get confused with the codebase as it is, is powerful reason to not confuse more, not to accept more confusing tests because there are precedents of confusing tests.

thecppzoo avatar May 27 '24 09:05 thecppzoo