gotenberg-php-client icon indicating copy to clipboard operation
gotenberg-php-client copied to clipboard

feat: Added Stream Functionality

Open zymawy opened this issue 5 years ago • 0 comments

A similar PR may already be submitted! Please search among the pull requests before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: Summary

I run into in satiation where I just want to stream the merged files directly to the client. instead of saving it or forcing the client to save the merged file into their machine. by this PR, I just added the functionality the make response serve as streamed file

For more information, see the CONTRIBUTING guide.

This PR fixes/implements the following bugs/features

  • [ x ] Stream File Into Browser

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output.

Closing issues

Fixes #

Checklist

  • [x] Have you followed the guidelines in our CONTRIBUTING guide?
  • [x] Have you lint your code locally prior to submission (make lint)?
  • [x] Have you written new tests for your core changes, as applicable?
  • [x] Have you successfully ran tests with your changes locally (make tests)?
  • [x] I have squashed any insignificant commits
  • [ ] This change has comments for package types, values, functions, and non-obvious lines of code

zymawy avatar Dec 11 '20 13:12 zymawy