synthwave-x-fluoromachine-epic-animations icon indicating copy to clipboard operation
synthwave-x-fluoromachine-epic-animations copied to clipboard

Better install

Open Lawrenco opened this issue 3 years ago • 3 comments

Hey I've created this extension pack, to make the installation a bit easier. You only need to run in terminal "code --install-extension synthwave-installer-0.0.1.vsix" and it will install the theme + custom CSS and JS Loader. Then all you need to do is to change the settings.json and the theme.

Installer.zip

Lawrenco avatar Jun 17 '22 17:06 Lawrenco

Hey, sounds great. Unfortunately I don't see any code changes from you?

What exactly are you going to do with the zip file? Creating the *.vsix file is part of the build process.

I suggest you best check in your code changes in a new pull request, then I can look at the code in general. We are in the open source world here 😁

thecodemonkey avatar Jun 19 '22 08:06 thecodemonkey

Hey so there arent any code changes in your file. The only difference is, the extension pack I've created. If you download it and run it (code --install-extension synthwave-installer-0.0.1.vsix). It is installing both of the needed extensions. So it is kind of merging two steps into one. Hope this explains a bit more :D

Lawrenco avatar Jun 20 '22 12:06 Lawrenco

Yes, I understand the benefit of your suggestion. The installation is currently not optimal and your solution should bring an improvement.

What I don't understand is how your solution should be adapted to the installation process:

  1. how exactly the file "synthwave-installer-0.0.1.vsix was created" ?
  2. how exactly should the installation process look like from the user's point of view?

Usually it works like this:

  1. the *.vsix file is created as an artifact during the build process.
  2. this file is uploaded to the VS Code Marketplace and can be found there
  3. the user finds the theme in the marketplace (browser or VS Code) and clicks on the install button.
  4. optionally the user can download the theme in the browser and install it manually. This is done by max. 2 to 3 % of all users, the majority is more than 97% of all users install the theme directly from VS Code by clicking on the install button.

thecodemonkey avatar Jun 21 '22 12:06 thecodemonkey