Mishahal Palakuniyil

Results 26 comments of Mishahal Palakuniyil

Sorry, I got a little busy with some other stuff. I was reviewing the heuristic again and I noticed ``` def make_function_maker_handler_event(function_maker_handler_event_factory): """This is a Google-style docstring with long args....

Can you direct me where I would need to implement the checks? I was thinking of doing it after extracting the arg but now I am thinking we should do...

Cool, I think I understand the heuristic. I was looking at `_consume_google_args_line` and it seems like we are doing `line_info.remaining.split(':', 1)` and then calling the _get_or_create_arg_by_name function where the arg...

Please review PR #476. I decided to define the states up front where you had initially mentioned. This is because `_get_or_create_arg_by_name` (where the google args are defined) is called only...

I was running pylint and pytest and all my lines of code are too long for pylint 😅. I also encountered an issue while running pytest with asyncio. I can...

Thank you! I am working on it; I have a question for you tho. ``` function_maker_handler_event_factory1: The function-maker-handler event factory ``` if we take the above example, the line length...

Cool will make the threshold 40%. > If it was working prior to this change, we should aim to ensure it stays working. If it already wasn't working, we can...

Awesome! I am adding some test cases and I noticed that when the `max length` is 90 and the `line1 + first_word_line2` is 83, it happens to take it as...

Can I work on this? Would I just have to move the application of case-sensitive to the functions mentioned in the above comment?