web-frameworks icon indicating copy to clipboard operation
web-frameworks copied to clipboard

Please add the libhv library

Open leamus opened this issue 3 years ago • 9 comments

Please add the libhv library, which is also a very good and few C/C++ Library: https://github.com/ithewei/libhv

leamus avatar Aug 25 '22 13:08 leamus

Hello,

Thanks for proposal. Any PR is gladly welcome.

However, we require explicit consent from author of any framework in here, or any active contributor (without any disapproval in 10 days we consider that consent is given).


Did you consent to add libhv in here @ithewei ?


This project compare performance based on 3 routes :

  • GET /, SHOULD return a successful status code and an empty string
  • GET /user/:id, SHOULD return a successful status code and the id
  • POST /user, SHOULD return a successful status code and an empty string

Regards,

waghanza avatar Aug 25 '22 13:08 waghanza

Yes, I agree very much

leamus avatar Aug 26 '22 00:08 leamus

Any PR is welcome then, and will be quickly reviewed

waghanza avatar Aug 26 '22 13:08 waghanza

Does a network library categories as web framework?

jamesli2021 avatar Aug 30 '22 16:08 jamesli2021

It could, imho. A library is a piece of consistent toolset used to build a bigger app.

For example, you can avoid using expressjs, and use pure node to build your app / service

waghanza avatar Aug 30 '22 18:08 waghanza

Hello, has libhv been added to the project?

leamus avatar Sep 11 '22 04:09 leamus

Not all all. Glad to receive any PR

waghanza avatar Sep 11 '22 11:09 waghanza

Can you tell me when to add?

leamus avatar Sep 11 '22 11:09 leamus

You need to implement of https://github.com/the-benchmarker/web-frameworks/issues/5573#issuecomment-1227272960 in cpp folder

waghanza avatar Sep 11 '22 15:09 waghanza

@waghanza @leamus isn't the author of the libhv, and the author have not express his interest to participate in the benchmark.

Anyway, my personal benchmark found libhv is on par with Go Echo, Gin, Chi.

jamesli2021 avatar Oct 04 '22 08:10 jamesli2021

@jamesli2021 who is the author then ?

if any core contributor is opposed to include libhv here, we shall respect this choice

waghanza avatar Oct 04 '22 15:10 waghanza

The author is HeWei. He asked me to apply for the test here, but I didn't know how to do it, so I asked here

leamus avatar Oct 04 '22 16:10 leamus

just create a basic project that implement 3 endpoints (described above) :-)

waghanza avatar Oct 04 '22 19:10 waghanza

Thanks, I'll try

leamus avatar Oct 06 '22 14:10 leamus

I have finished the example project. How can I upload it?

leamus avatar Oct 11 '22 08:10 leamus

Make a PR in this project ❤️

waghanza avatar Oct 11 '22 11:10 waghanza

Maybe if you have problem with how to create PR, I suggest you could zip the source code and reply here.

jamesli2021 avatar Oct 14 '22 13:10 jamesli2021

or send me by email @leamus

waghanza avatar Oct 14 '22 13:10 waghanza

I have successfully created the PR, but I am not very good at using CMake (I often use qmake). If you can help me to modify it, thank you very much. https://github.com/the-benchmarker/web-frameworks/actions/runs/3238749453

----- 原始邮件 ----- 发件人:jamesli2021 @.> 收件人:the-benchmarker/web-frameworks @.> 抄送人:深林孤鹰 @.>, Mention @.> 主题:Re: [the-benchmarker/web-frameworks] Please add the libhv library (Issue #5573) 日期:2022年10月14日 21点47分

Maybe if you have problem with how to create PR, I suggest you could zip the source code and reply here.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

leamus avatar Oct 15 '22 03:10 leamus

I am not sure qmake is the standard way to compile C++ but anyway, feel free to push any qmake and write here some instruction about how to compile it 😛

waghanza avatar Oct 15 '22 08:10 waghanza

qmake is the construction tool of Qt, and it is no longer updated, so don't worry about it~😛 ----- 原始邮件 ----- 发件人:Marwan Rabbâa @.> 收件人:the-benchmarker/web-frameworks @.> 抄送人:深林孤鹰 @.>, Mention @.> 主题:Re: [the-benchmarker/web-frameworks] Please add the libhv library (Issue #5573) 日期:2022年10月15日 16点54分

I am not sure qmake is the standard way to compile C++ but anyway, feel free to push any qmake and write here some instruction about how to compile it 😛

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

leamus avatar Oct 15 '22 13:10 leamus