thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Docs: Add sidecar and compactor metrics

Open mercenarysre opened this issue 1 year ago • 5 comments

Thanos components: add sidecar and compactor metrics; kindly review @douglascamata.

mercenarysre avatar Jul 05 '24 18:07 mercenarysre

Can you please update the PR title to match the convention in the repository? My suggestion is docs: Add sidecar and compactor metrics.

By the way, after our conversation in Slack I thought there was going to be one PR per component. But don't worry, that's not a requirement for this case.

douglascamata avatar Jul 09 '24 10:07 douglascamata

Can you please update the PR title to match the convention in the repository? My suggestion is docs: Add sidecar and compactor metrics.

By the way, after our conversation in Slack I thought there was going to be one PR per component. But don't worry, that's not a requirement for this case.

I have updated the PR title to match the convention in the repository.

I will make sure to do one PR per component going forward; by waiting for one component PR to be merged, then updating my forked repo with the Thanos main repo and doing git pull locally.

mercenarysre avatar Jul 09 '24 11:07 mercenarysre

@TomiwaAribisala-git you don't need to wait for one component PR to be merged to prepare the next. They are independent changes in totally different files. You can go ahead and open all the PR at the same time if you want. Up to you. 👍

douglascamata avatar Jul 09 '24 12:07 douglascamata

new compactor metrics added.

mercenarysre avatar Jul 10 '24 21:07 mercenarysre

Updated Sidecar and Compactor metrics, @douglascamata.

mercenarysre avatar Jul 24 '24 15:07 mercenarysre