thanos icon indicating copy to clipboard operation
thanos copied to clipboard

Help minio-go with over-allocations on Multi-Part Upload

Open bwplotka opened this issue 4 years ago • 3 comments

See: https://github.com/minio/mc/issues/3376#issuecomment-805994723

Currently to mitigate issue on our side from this https://github.com/thanos-io/thanos/issues/3917 we had to revert that particular commit and use tmp fork instead: https://github.com/bwplotka/minio-go/commit/f9927e5255a6ade9d3728e2651c6ae24f4367692

This issue is to figure out long term solution that will work for us and for minio client. The reason why we can revert it and minio not, is because we don't make concurrent uploads.

bwplotka avatar Mar 24 '21 17:03 bwplotka

This is not done, with still are on my fork, and we need to fix minio upstream in a way that will not produce race and will be efficient in the same time 🤗

bwplotka avatar Mar 26 '21 22:03 bwplotka

Contributed the latest, even further optimized version: https://github.com/minio/minio-go/pull/1673

bwplotka avatar Jul 05 '22 15:07 bwplotka

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] avatar Sep 21 '22 02:09 stale[bot]

@bwplotka I guess this can be closed now?

douglascamata avatar Dec 27 '22 10:12 douglascamata