emacs-hnreader icon indicating copy to clipboard operation
emacs-hnreader copied to clipboard

ill-advised var setting

Open agzam opened this issue 3 years ago • 0 comments
trafficstars

Thank you for this package. As a frequent HN reader, I was a bit skeptical, but it turned out to be really nice.

If I may, I have a small suggestion. I just started using the package, at some point, perhaps I come up with some other things.

In the readme, you suggest setting org-confirm-elisp-link-function. I don't think that is very wise. Elisp links can be dangerous, since they can run any arbitrary shell command.

I would recommend adding a hook that would run whenever *HN* buffer gets created. That way you can set it locally in the buffer:

(setq-local org-link-elisp-confirm-function nil)

Also, org-confirm-elisp-link-function is now obsolete.

agzam avatar Nov 01 '22 05:11 agzam