react-native-safe-area-context icon indicating copy to clipboard operation
react-native-safe-area-context copied to clipboard

Published 20 hours ago • verified publisher icon th3rdwave

Add required architecture only check

Open fgagneten opened this issue 3 years ago • 0 comments

Summary

When you are building on android using the new architecture, required architecture check is missing.

Running the command: react-native run-android --active-arch-only will fail if you don't first build for every single arch (react-native run-android)

Test Plan

  1. Try to run react-native run-android --active-arch-only in a project that implements react-native-safe-area-context as a first command and it will failed with the following error:

fcntl(): Bad file descriptor /Users/username/Library/Android/sdk/ndk/21.4.7075529/build/core/prebuilt-library.mk:45: *** Android NDK: Aborting . Stop. Android NDK: Check that /Users/username/XX/source/XX-mob/XX/android/app/build/react-ndk/exported/x86/libfb.so exists or that its path is correct --> As I'm running just for armeabi-v7ax86 arch will not exist

fgagneten avatar Aug 06 '22 22:08 fgagneten