Ozan Tezcan
Ozan Tezcan
Yes, one reason is that. More importantly, I don't see any benefit of using it(for my use-cases). I guess that flag is just for very specific applications. Why do you...
I remember I experimented with with EPOLLET years ago and decided it wasn't making performance any better(for my use-case). Also, it makes your app a bit complex. Personally, I've never...
Yes, totally I agree. If you fill output buffer of the socket continously, it might be noticable. Just it’s never been the case for me. If you are sending small...
Sure, it’d be great!
We have to do it for `WSAPoll` if I remember correctly. For `epoll` or `kqueue`, it is not necessary but I wanted have all possible events in one go. If...
> and that leads to a follow up Q, if (true) every RedisModuleCtx has its own allocated ctx->client, why in RM_Call do we need to "allocate" a temp client to...
Yes, it will require proper version check. Also, if a module wants to support older Redis versions, it won't be able to use this. So, this is for modules that...
In addition to macro check, we can still add null check into the function itself. Even though we'll never hit that code, one can read that function and realize null...
I always take a look at function implementation before using it. It'd take some time for me to figure out there is a hidden null check in the header. I...
Yeah, maybe. I don't have a strong opinion anyway. If you guys think this is good enough, let's do it.