erlang.tmbundle icon indicating copy to clipboard operation
erlang.tmbundle copied to clipboard

Published 20 hours ago • verified publisher icon textmate

Fix `~"` syntax

Open garazdawi opened this issue 5 years ago • 3 comments

If a string ends with a ~" we cannot know if it is a valid control character or not, so we should not show it as an error.

This fixes #19 and https://github.com/erlang-ls/erlang_ls/issues/730

garazdawi avatar Nov 24 '20 13:11 garazdawi

@sorbits @infininight This PR has been open for more than a month, so we suspect the repository is not actively maintained.

We use this repo as a submodule in the Erlang LS VS Code extension. We are wondering what the status of this repository is. We are willing to help maintaining this. In the worse case, we could fork this under the Erlang LS organization. Any opinions?

robertoaloi avatar Dec 27 '20 22:12 robertoaloi

It looks like I already raised this in https://github.com/textmate/erlang.tmbundle/issues/20 (which I forgot about). I think it makes sense to keep them TextMate compatible. How should we proceed?

robertoaloi avatar Dec 28 '20 18:12 robertoaloi

@garazdawi I forked the grammar in: https://github.com/erlang-ls/grammar so it can be included in the VS Code extension in isolation. The README states the origin of the grammar and credits this repository. I'd suggest we keep developing the grammar there (there are other possible improvements) and then contribute it back to this repository.

robertoaloi avatar Dec 29 '20 12:12 robertoaloi