testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

Updated react hooks example page to match react-hooks-testing-library's documentation

Open ab18556 opened this issue 6 years ago • 8 comments

I updated the current pull request to match react-hooks-testing-library's doc. I removed the blog page since it is not true anymore and I also removed testHook from the api since it is not a part of it anymore.

ab18556 avatar Mar 22 '19 21:03 ab18556

@alexkrolick, I think you can close this now. react-hooks-testing-library recently merged a change to stop using react-testing-library for rendering, so I'm not sure it's still appropriate for it to appear in these docs.

We still follow the same principals, but the say we're part of the testing-library ecosystem is not technically true anymore.

mpeyper avatar Apr 26 '19 20:04 mpeyper

I don't think not having a hard dependency on RTL is a requirement; I would say it belongs in the same "Ecosystem" category as jest-dom and native-testing-library -- libs that share the overall approach and complementary features.

https://testing-library.com/blog/2019/04/25/new-org

alexkrolick avatar Apr 26 '19 21:04 alexkrolick

Agreed Alex.

kentcdodds avatar Apr 26 '19 22:04 kentcdodds

Ok cool. I'm happy for this to continue then :)

mpeyper avatar Apr 27 '19 11:04 mpeyper

I also let @mpeyper know that the change to no longer require react-testing-library was actually a huge help to native because now we can leverage his library as well for writing hooks tests 🎉

bcarroll22 avatar Apr 29 '19 01:04 bcarroll22

Oh nice!

kentcdodds avatar Apr 29 '19 01:04 kentcdodds

I'm not sure about the current state of this library - is this PR accurate or do we need a reboot?

alexkrolick avatar Oct 01 '20 22:10 alexkrolick

The library is still active, and the examples shown here are still accurate (our API hasn't changed much), but some of the descriptions and links are not quite right anymore. We aren't using react-testing-library any more and the links point to the the old location before it was brought into the testing-library org.

mpeyper avatar Oct 01 '20 22:10 mpeyper