testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

Remove all references to Create React App

Open Mikilll94 opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe.

We should remove all the references to Create React App. CRA is deprecated and no longer recommended in React docs.

Currently we have a reference to CRA here: https://testing-library.com/docs/react-testing-library/intro/

Describe the solution you'd like

Remove reference to CRA from here: https://testing-library.com/docs/react-testing-library/intro/

Mikilll94 avatar Aug 22 '23 06:08 Mikilll94

Hi @Mikilll94 :) Even though CRA is not recommended anymore, most of our users are probably still using CRA as it's still the de-facto standard and since we're not the React core team, we don't need to push these changes yet as we're aiming to help our users. I think we can keep this one open but I wouldn't go ahead and push a fix just yet.

MatanBobi avatar Aug 22 '23 06:08 MatanBobi

I disagree, I believe Vite is superior to Create React App, and because the React core team no longer recommends it for beginners we should follow.

nickserv avatar Sep 05 '23 06:09 nickserv

I disagree, I believe Vite is superior to Create React App, and because the React core team no longer recommends it for beginners we should follow.

IMO there's a difference between removing every reference to just replacing it with create-vite-app. Either way, the references are minor and I have no strong feelings either way, so w/e you choose is fine by me.

MatanBobi avatar Sep 05 '23 07:09 MatanBobi

I plan on replacing the note with a Vite template (possibly my own).

nickserv avatar Sep 05 '23 09:09 nickserv

Moving the note about it being preinstalled in some situations to the install/setup section might be helpful, given the usage of react-scripts is still pretty high

alexkrolick avatar Sep 07 '23 05:09 alexkrolick