testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

feat: support zh-Hans

Open xupea opened this issue 3 years ago • 9 comments

Two major changes:

  1. support i18n
  2. support zh-Hans(简体中文)
  3. up-to-date: 2023-03-10

xupea avatar Oct 18 '22 03:10 xupea

Deploy Preview for testing-library ready!

Name Link
Latest commit 5055c9b75522845e336cf946d0e2b49d0560db8a
Latest deploy log https://app.netlify.com/sites/testing-library/deploys/640a11efd642be000828c19b
Deploy Preview https://deploy-preview-1158--testing-library.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 18 '22 03:10 netlify[bot]

Hi @xupea! Thanks for working on this. It might take me some time to review this one but I'll put it on my list :)

MatanBobi avatar Oct 18 '22 06:10 MatanBobi

I believe translations is a good idea and 100% agree that we should add ground rules for the contribution guidelines and talk about it a bit before merging :)

MatanBobi avatar Oct 19 '22 17:10 MatanBobi

Docusaurus has good i18n support. Although it's likely there will be some divergence in the docs for different languages, it seems like a good thing to do. It would be nice to have a "translation lead" for each language that stays subscribed to this repo and tries to keep up with changes to the docs as the APIs change. Community contributions also welcome.

alexkrolick avatar Oct 20 '22 18:10 alexkrolick

@MatanBobi @alexkrolick

What happened to the translation initiative for the project?

I think this will increase the usage and access of the non-native English speakers and programmers to the current project.

nazarepiedady avatar Feb 22 '23 11:02 nazarepiedady

@nazarepiedady I didn't get the chance to review this one. I'll do my best to get to it soon :)

MatanBobi avatar Feb 23 '23 08:02 MatanBobi

@MatanBobi we need this feature as soon as possible, because this will increase the number of its users, mainly those that are non-English natives.

nazarepiedady avatar Feb 24 '23 04:02 nazarepiedady

Do we need to move English into i18n too?

nickserv avatar Feb 26 '23 13:02 nickserv

@nickmccurdy accordingly to the preview of the website, it seems to work well without it, but to keep consistency in the project and also to ease the understanding of the codebase I believe it is better to move the English version to i18h too if it is possible to do it.

nazarepiedady avatar Feb 26 '23 17:02 nazarepiedady