nightwatch-testing-library icon indicating copy to clipboard operation
nightwatch-testing-library copied to clipboard

Published 20 hours ago • verified publisher icon testing-library

chore: add tests for Node 16

Open MichaelDeBoey opened this issue 4 years ago • 3 comments

https://nodejs.medium.com/node-js-16-available-now-7f5099a97e70

MichaelDeBoey avatar Apr 21 '21 14:04 MichaelDeBoey

Technically, adding any engines here is a breaking change, since it could prevent installations from users on older Node versions. I think we should revert commit that unless we're ready to release this PR as a breaking change.

nickserv avatar Jul 18 '21 21:07 nickserv

It technically is, but since other versions weren't supported anyways, I don't see any problem with adding them as I did.

MichaelDeBoey avatar Jul 19 '21 11:07 MichaelDeBoey

We could publish this as a minor, and worst case if there are back compatibility issues (probably unlikely), we could revert it.

nickserv avatar Jul 20 '21 02:07 nickserv