workshop-manual-a11y-testing icon indicating copy to clipboard operation
workshop-manual-a11y-testing copied to clipboard

Match solution file to solution in video

Open Meganmccarty opened this issue 3 years ago • 1 comments

Fix exercise 1 solution to match video solution.

On the website, when reading through the solution for Manual Accessibility Testing > Keyboard Testing > Fix Focus and Operability Issues for Keyboard Interactivity > “Update MegaNav Button Styling”, there is some CSS that can be copied and pasted for button.megamenu-navitem. In this code snippet, color is set to inherit, but, in the video solution for this section, color isn’t changed (it is left set to var(--color-accent-mediumdark)).

By itself, this small discrepancy isn’t an issue. However, a later lesson (Manual Accessibility Testing > Testing with Tools & Browser Extensions > Identify Color Contrast Issues with Color Contrast Analyzer & Chrome DevTools > “Measuring Color Contrast Ratio”) assumes that color is still set to var(--color-accent-mediumdark) when describing how the Chrome DevTools color picker works. If a user doesn’t watch the video solution from the prior keyboard lesson and only reads that lesson’s text, then their code will not match the setup laid out in the color contrast lesson, which may lead to confusion.

I updated exercise1-keyboard/scss/_header.scss to match the video solution for the keyboard lesson. However, that lesson's text on the website also needs to be updated accordingly.

Meganmccarty avatar Sep 07 '22 19:09 Meganmccarty

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
workshop-manual-a11y-testing ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 7:29PM (UTC)

vercel[bot] avatar Sep 07 '22 19:09 vercel[bot]

Thanks for this, @Meganmccarty !!

marcysutton avatar May 30 '24 16:05 marcysutton