Andriy Tolstoy comments

Results 6 comments of


                                            Andriy Tolstoy

Swagger fails to load resources when my site is running under a virtual directory.

Not for OWIN: ``` c.RootUrl(req => req.RequestUri.GetLeftPart(UriPartial.Authority).TrimEnd('/') + '/' + req.GetRequestContext().VirtualPathRoot.TrimStart('/')); ```

Swagger fails to load resources when my site is running under a virtual directory.

For .NET Core use [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) instead.

use collection expression spread operator

Hi @mikeminutillo, it's not a particular issue fixing but rather a performance related one. ``` [SimpleJob(RuntimeMoniker.Net80)] [MemoryDiagnoser] public class Benchmark { private int[] visitedNodes; private const int NewNode = -1;...

use collection expression spread operator

Is an implicit deduplication using `Union` necessary? Could `visitedNodes` have some duplicates? There is an explicit [duplication check ](https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Features/FeatureActivator.cs#L148) here, isn't? ``` if (visitedNodes.Any(n => n == node)) { return...

remove unnecessary distinct method

It doesn't address any specific performance case now and can certainly wait.

use static equals method to avoid exception

The [previous line](https://github.com/DuendeSoftware/IdentityServer/blob/main/src/IdentityServer/Test/TestUserStore.cs#L42) checks explicit the possible null value for user password. > if (string.IsNullOrWhiteSpace(user.Password) Right. The type is for testing purpose only. Nevertheless we could use [Object.Equals](https://learn.microsoft.com/en-us/dotnet/api/system.object.equals) or [String.Equals](https://learn.microsoft.com/en-us/dotnet/api/system.string.equals)...