testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

feat(vault): add support for HashiCorp Vault container

Open f4z3r opened this issue 2 years ago • 1 comments

Add support for a Vault container.

f4z3r avatar Jul 04 '23 16:07 f4z3r

@tillahoffmann Am I correct in assuming I need to wait for workflow approval before I can continue to update the dependencies for this PR?

f4z3r avatar Aug 04 '23 08:08 f4z3r

Hi @f4z3r!

Thank you for your contribution, Hashicorp's Vault is something we would like to see supported. We are sorry for the extended delay in feedback and merged PRs, but are now on back on track with active maintainers.

Could you please rebase or merge in the latest changes from main? That way we can start moving this PR forward

santi avatar Apr 03 '24 13:04 santi

@santi sure thing. I will get to it over the next couple of days 👍🏽

f4z3r avatar Apr 03 '24 13:04 f4z3r

@santi alright I updated the PR to be according to the new repo structure. I am not super familiar with Poetry, but it seemed I needed to update the entire lock file to install the required packages I added to run the tests. As far as I could check, it seems to run fine, make modules/vault/tests ran the tests successfully.

f4z3r avatar Apr 04 '24 17:04 f4z3r

Good work so far, @f4z3r! With this speed we are ready to merge the module today 😄

santi avatar Apr 05 '24 07:04 santi

Tests are failing because the specified extra vault does not exist. You can add it in pyproject.toml under [tool.poetry.extras] as vault = [] (Same as the kafka entry in the list)

santi avatar Apr 05 '24 08:04 santi

Good work so far, @f4z3r! With this speed we are ready to merge the module today 😄

Well thanks for the quick reviews and your help! 😄

f4z3r avatar Apr 05 '24 08:04 f4z3r

Great work! 💯 Thank you for your contribution.

Looks like Github Actions hit a bit of a bump right when everything was done, so only half of the checks have passed, and I'm getting 500 Errors randomly. Once https://github.com/testcontainers/testcontainers-python/actions/runs/8567034738, https://github.com/testcontainers/testcontainers-python/actions/runs/8567034549 and https://github.com/testcontainers/testcontainers-python/actions/runs/8567034548 have run, I'll merge 👍

Yup, seems GitHub is experiencing issues: https://www.githubstatus.com/

f4z3r avatar Apr 05 '24 08:04 f4z3r

@f4z3r Seems like the trouble is over, but the queued tasks are not running. Could you re-trigger a new set of checks by pushing a commit with git commit --allow-empty -m "Re-trigger PR checks"?

santi avatar Apr 05 '24 09:04 santi