testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Add ability to expose both http and native ports for clickhouse (#257)

Open yakimka opened this issue 3 years ago • 2 comments
trafficstars

Fixed #257

yakimka avatar Oct 31 '22 18:10 yakimka

@yakimka, sorry for the slow follow up on this. Would you mind rebasing on master? I'm also planning a major-version release so we can squeeze in the breaking change of dropping the port argument. I'm breaking a bunch of other things in #296.

tillahoffmann avatar Feb 17 '23 02:02 tillahoffmann

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (472da35) to head (618b83d). Report is 301 commits behind head on main.

Files Patch % Lines
testcontainers/clickhouse.py 62.50% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   85.93%   85.65%   -0.28%     
==========================================
  Files          28       28              
  Lines         782      788       +6     
  Branches       77       78       +1     
==========================================
+ Hits          672      675       +3     
- Misses         81       83       +2     
- Partials       29       30       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 09 '24 15:03 codecov-commenter